Skip to content
This repository was archived by the owner on May 13, 2025. It is now read-only.

Allow user to set calls per minute in the RateLimiter#127

Open
ctoestreich wants to merge 2 commits into
github:masterfrom
ctoestreich:master
Open

Allow user to set calls per minute in the RateLimiter#127
ctoestreich wants to merge 2 commits into
github:masterfrom
ctoestreich:master

Conversation

@ctoestreich

@ctoestreich ctoestreich commented May 18, 2017

Copy link
Copy Markdown

Allow user to provide a param callsPerMinute via configuration block to allow more calls per minute to github. Without param default is 20. This will address some issues from #90 #17 #28 #88 @jakeswenson @alem0lars @bguerin @kevinsawicki

User can configure the following

            <plugin>
                <groupId>com.github.github</groupId>
                <artifactId>site-maven-plugin</artifactId>
                <version>0.13-SNAPSHOT</version>
                <configuration>
                    <callsPerMinute>1000</callsPerMinute>
                </configuration>
            </plugin>

coestre added 2 commits May 18, 2017 13:41
Adding ability to over ride the callsPerMinute in the rate limiter to…
1f9a812 
… allow faster git stuff to GHE or non-public githubs
Adding ability to over ride the callsPerMinute in the rate limiter to…
f965310 
… allow faster git stuff to GHE or non-public githubs
bguerin
bguerin approved these changes May 18, 2017
View reviewed changes

@bguerin bguerin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can avoid gratuitous formating which make the PR hard to read.
Otherwise, great !

@ctoestreich

ctoestreich commented May 21, 2017

Copy link
Copy Markdown
Author

I tried to unwind all the tab v spaces that I would but there is no code style profile in the project and some of the formatting is a bit unclear like 1 space + 1 Tab for indents in java files. I had a hard time reproducing that format with my current style settings in IntelliJ. :)

@bguerin

bguerin commented May 21, 2017

Copy link
Copy Markdown
Contributor

I understand. On projects like this (without formatting settings shared), I just does not automatically format sources with my IDE.

@ctoestreich

ctoestreich commented May 8, 2018

Copy link
Copy Markdown
Author

@bguerin Just checking on this as we near the 1yr mark.

@bguerin

bguerin commented May 8, 2018

Copy link
Copy Markdown
Contributor

And ? I am not a maintainer of these plugins, I only contributed to them ...
I do not have rights to merge ...

@ctoestreich

ctoestreich commented Jun 12, 2018

Copy link
Copy Markdown
Author

Who is a maintainer?

@ctoestreich

ctoestreich commented Jun 12, 2018

Copy link
Copy Markdown
Author

@kevinsawicki

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bguerin bguerin bguerin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ctoestreich @bguerin